[Minor] Ambiguous null/empty string representation

[Meems33]

Hi,

Something minor I noticed that I wasn't sure was intentional or not. The TagNodeString defaults the internal data value to "" and forces it to be "" when passed in through the constructor. The property however has no such guard meaning that the value can intentionally be set to null.

Is it valid for a TAG_STRING to have a null data value? I ask because it effects how Serialization/Deserialization of TagNodes behaves.

[Meems33]

Appendum: Similar questions apply to TagNodes that have internal object representations. The classes look like they assume that the data will never be null. Is that a safe assumption?

[jaquadro]

It turns out that it's not a safe assumption. The writing logic is in https://github.com/jaquadro/Substrate/blob/master/SubstrateCS/Source/Nbt/NbtTree.cs and there's definitely no null check handling. It's an oversight.