Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use github_team_members for authoritative members management #61

Open
RafPe opened this issue Aug 24, 2022 · 5 comments · May be fixed by #65
Open

feat: Use github_team_members for authoritative members management #61

RafPe opened this issue Aug 24, 2022 · 5 comments · May be fixed by #65
Assignees
@mariux

Comments

@RafPe
Copy link

RafPe commented Aug 24, 2022

Hey there!

First of all great module 💪 While using it I noticed there is the possibility to use github_team_members to manage team membership so terraform becomes ultimately authoritative for the resource.

I would be happy to make a PR if u would be open to such change.
@soerenmartius
Copy link
Member

Hi @RafPe ,

Thanks for your suggestion! Let me talk to the team tomorrow and come back to you :) Also, thanks for offering to contribute through PRs - we encourage you to do that!

Thanks!

@RafPe
Copy link
Author

RafPe commented Sep 7, 2022

@soerenmartius any update ? Are you guys open for that kind of change ?

@tobiasehlert
Copy link

Hello there,

Great suggestion @RafPe ⭐

Using github_team_members should considerably decrease the use of the GitHub API, so this is almost required to go that way when running larger organisations.

How have the thoughts been @soerenmartius and @mariux regarding this?

Kind regards,
Tobias

@tobiasehlert tobiasehlert linked a pull request Apr 27, 2023 that will close this issue
Open
@tobiasehlert
Copy link

Created PR #65 to add this feature :)

@RafPe
Copy link
Author

RafPe commented Nov 15, 2023

@soerenmartius any updates on the possible merge ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariux mariux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support to use github_team_members tobiasehlert/terraform-github-team
4 participants
@mariux @soerenmartius @tobiasehlert @RafPe