Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include full AWS asset package of icons #764

Closed
jpreszler opened this issue Oct 14, 2022 · 7 comments · Fixed by #1026
Closed

Include full AWS asset package of icons #764

jpreszler opened this issue Oct 14, 2022 · 7 comments · Fixed by #1026
Assignees
Labels
area/provider/aws AWS provider comp/node Issue of node component

Comments

@jpreszler
Copy link

There are a lot of AWS icons missing. Could the entire icon asset package at https://aws.amazon.com/architecture/icons/ be included?

@mingrammer
Copy link
Owner

I'll update it soon. Thank you for informing us.

@mingrammer mingrammer added comp/node Issue of node component area/provider/aws AWS provider labels Nov 8, 2022
@bdsoha
Copy link
Contributor

bdsoha commented Nov 9, 2022

@jpreszler This is ~60Mb of images alone.

@gabriel-tessier
Copy link
Collaborator

@mingrammer
I can check and add the missing icons if you want.

@bdsoha 60 Mb it's the size of the zip file (uncompressed is 63Mb), but inside there's different size, theme and format of the same file as written above the link.

Package contains sets for both dark and light backgrounds in both PNG and SVG file formats.

But I think that @bdsoha raise a concern about the size of the resource directory and by extension the lib file. The more provider and icons are added the more the file will become heavy. On master the resources directory is 24Mb not yet big but we may start to think about alternative idea before reaching 100Mb.
We can talk about in discuss or in another issue. So far I thought about 2 alternatives:

@bdsoha
Copy link
Contributor

bdsoha commented Nov 9, 2022

@gabriel-tessier I mentioned some of those options here, in regard to optimizations.

@gabriel-tessier
Copy link
Collaborator

Thanks for the link I mess this issue sorry for the noise.

@bdsoha
Copy link
Contributor

bdsoha commented Nov 9, 2022

@gabriel-tessier It would be great to record your ideas on that issue.

@karim-soufi
Copy link

Hello,

Any updates regarding this issue?
one of the missing icons is ECS Task Definition wich is a very popular service.

@tvqphuoc01 tvqphuoc01 self-assigned this Oct 7, 2024
@tvqphuoc01 tvqphuoc01 linked a pull request Oct 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/aws AWS provider comp/node Issue of node component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants