Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon is not updated when Site URL changes #1555

Closed
adambubenicek opened this issue Aug 29, 2022 · 2 comments · Fixed by #2871
Closed

Favicon is not updated when Site URL changes #1555

adambubenicek opened this issue Aug 29, 2022 · 2 comments · Fixed by #2871
Labels

Comments

@adambubenicek
Copy link

Feed's favicon seems to be initially derived from Site URL, but new favicon is not fetched when user edits Site URL later. The only workaround right now seem to be deleting the feed and importing it through OPML with proper htmlUrl attribute.

I think fetching a new favicon when modifying feed would completely fix #1260, and also fix some usecases behind #1438, #1243, and #590.

Thanks, and thanks for Miniflux!

@sabieber
Copy link

sabieber commented Oct 4, 2024

This is the only thing that bugs me as well when using Miniflux.
Is there any news on when the linked PR may be merged?

@fguillot fguillot linked a pull request Oct 5, 2024 that will close this issue
5 tasks
@sabieber
Copy link

sabieber commented Oct 5, 2024

@fguillot wow thanks a lot. Looking forward to the new version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants