Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substack comments #2828

Open
1 task done
emilknievel opened this issue Sep 1, 2024 · 2 comments
Open
1 task done

Substack comments #2828

emilknievel opened this issue Sep 1, 2024 · 2 comments

Comments

@emilknievel
Copy link

Unsure if this should be a feature request or a bug but here goes:

I have noticed that articles from Substack don't have a link to the comments. I really appreciate having that option when I'm reading hackernews links etc. and would love for the same to exist for the articles from substack.

Best regards,
Emil

@moppman
Copy link

moppman commented Sep 2, 2024

I'm not sure this is feasible.

For hackernews feed items[0], miniflux displays a comments link because it's part of the actual RSS feed.

From the RSS spec:

<comments> is an optional sub-element of <item>

and also here in miniflux' implementation:

CommentsURL string `xml:"rss comments"`

Unfortunately, Substack[1] does not provide the <comments> element for their feeds.

That means miniflux would need some custom logic that adds a https://substack_url.com/comments[2] link to each entry.


[0]: hackernews feed example: https://news.ycombinator.com/rss
[1]: random Substack feed example: https://www.astralcodexten.com/feed
[2] random Substack comments link example: https://www.astralcodexten.com/p/open-thread-345/comments

@emilknievel
Copy link
Author

Ah, I see. Thank you for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants