-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per feed retention policy #770
Comments
I'd like to keep them all forever unless I mark them as read, then they can go away. So maybe have an option to keep them permanently unless otherwise noted. |
Do you run your instance for a long time? I have hundreds of feeds with a retention rate of 3 years now, and still have a DB of 3GB only, so this sounds a good feature. |
The cleanup policy should apply to read items only. Unread items should be kept forever. This should be true even in current version. |
Just an FYI I'm using the hosted instance for now. |
In the latest version, we had two global config options: CLEANUP_ARCHIVE_READ_DAYS and CLEANUP_ARCHIVE_UNREAD_DAYS. The original proposal said we want to set the number of entries to keep per feed. It is difficult to write the SQL query. |
Is this feature approved to implement? @fguillot |
There should just be a global one for all feeds. Why should I ever have to go into the terminal to change that? |
In other words, it should just continue to persist the way it is. |
@shizunge how does it look like with this feature? I am willing to look into it. Would it be accepted if I do? |
I don't have time on it right now. I believe we need to
I am also thinking that probably we should only let user set a shorter retention period (than the global ones) to avoid users abuse the system. Then we should also support unlimited global retention policy (e.g. CLEANUP_ARCHIVE_READ_DAYS=-1 or something similar) |
Awesome, thanks for guidance :) I'll try my best |
(context: I have miniflux deployed on my RPi and I'm sole user). As in the original message - it would be awesome to mark some feeds as "retain forever" (mostly those "low traffic", to have complete archive). Currently for those low traffic feeds I simply mark all entries with star but it's not really convenient and it may slip by me sometime thus a feed-option "keep items forever" would be very welcomed. |
Today there is only one global retention policy, which is controlled by a global parameter CLEANUP_ARCHIVE_READ_DAYS.
For some blogs, I want to keep articles as long as possible. For some news feeds, I do not need to keep many items that long.
It would be great if there is an option let us set per feed retention policy: 1. days to keep, 2. max items to keep.
I think this can be done in two steps:
Add maximum items per feed as a globle retention policy.
Update the cleanup routine: Iterate all feeds and archive items for each feed. (Like the fresh routines, but this can be done using only 1 worker I think.)
Then add a new global parameter: CLEANUP_MAX_READ_ITEMS_PER_FEED to control the max items per feed to keep.
Set the parameter to 0 to store unlimited items. (Still subject to CLEANUP_ARCHIVE_READ_DAYS)
Add an option to set per feed retention policy. If not set, use the global policy default.
This step probably can be done together with [Feature request] Fresh frequency setting for single feed #412 (Fresh frequency setting for single feed)
The text was updated successfully, but these errors were encountered: