-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview not taking mime-type into account but only file extension #2919
Comments
The reason we do that is because to know content-type we have to spend an additional API call on the object. We want things to be simple. Preview itself is good to have functionality not a fundamental feature here. What you are asking goes beyond this and making its scope larger. Just name the file appropriately, it is human friendly and useful for everyone. |
Apparently this is the wrong repository and searching in the right one turned up it's a duplicate #2573 |
In that case we can provide preview. |
Thank you @ssendev . for the supported preview types, we will also add |
The preview at the right only works if the file name ends in .png or another image extension if it has no extension the preview is disabled.
Expected Behavior
Enable the preview button if a compatible mime type is set
Current Behavior
The prieview button is disabled even if an image mime type is set
Steps to Reproduce (for bugs)
foo.png
foo
and set the mime type toimage/png
foo.png
has a the preview whilefoo
has notContext
The correct mime type is listed at the bottom and is also returned when generating a share url.
Your Environment
minio --version
): RELEASE.2023-06-29T05-12-28Z (commit-id=aae684641325e1c37375d455c790e58d902bd7b6)The text was updated successfully, but these errors were encountered: