Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions for the ComposeObject method #1258

Open
senyuan1135 opened this issue Feb 1, 2024 · 2 comments
Open

Suggestions for the ComposeObject method #1258

senyuan1135 opened this issue Feb 1, 2024 · 2 comments

Comments

@senyuan1135
Copy link

Headers ['x-amz copy source '] escape with encodeURI before the second assignment
@prakashsvmx
Copy link
Member

We will check @senyuan1135 ,

adding more details about the issue or contributing a fix with a PR would also be helpful.

@senyuan1135
Copy link
Author

@prakashsvmx
In line 2510 of the src/minio.js file, the method getHeaders() has already escaped headers ['x-amz copy source '] with encodeURI, but it is overwritten by code 2510 that does not escape

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prakashsvmx @senyuan1135