Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

able to add the sidecar and initcontainer memory resources through HelmChart #2266

Open
rajasekharbh opened this issue Aug 12, 2024 · 4 comments
Assignees

Comments

@rajasekharbh
Copy link

with the operator helm charts(5.0.13 or 6.0.1) the sidecar and validate-arguments containers are getting resource empty and values.yaml doesn't have the resources set for the init and sidecar. if we don't set the values validation webhook is not allowing to create the pod.

warning FailedCreate 20s (x17 over 5m49s) statefulset-controller create Pod myminio-tenant-pool-0-0 in StatefulSet myminio-tenant-pool-0-0 failed
error: admission webhook "validating-webhook.openpolicyagent.org" denied the request:
the pod "myminio-tenant-pool-0-0", in namespace "minio-tenant", did not specify cpu limits resources,
the pod "myminio-tenant-pool-0-0", in namespace "minio-tenant", did not specify cpu requests,
the pod "myminio-tenant-pool-0-0", in namespace: "minio-tenant", did not specify memory limits resources,
the pod "myminio-tenant-pool-0-0", in namespace: "monio-tenant", did not specify memory request resources.
https://github.com/minio/operator/blob/v5.0.13/helm/operator/values.yaml

if we set the resourcequota at namespace level, we are getting below error.

Warning FailedCreate 100s (x17 over 7m8s) statefulset-controller create Pod myminio-tenant-pool-0-0 in StatefulSet myminio-pool-0 failed
error: pod "myminio-tenant-pool-0-0" is forbidden:
failed quots: minio-quota: must specify limits.cpu for : sidecar,validate-arguments;
limits,memory for : sidecar,validat-arguments;
requests,cpu for sidecar,validate-arguments;
requestss,memory for: sidecar,validat-arguments

@ramondeklein
Copy link
Contributor

This was also reported in #1287 (comment).

@ramondeklein
Copy link
Contributor

I guess you're using a custom pod admission controller?

@rajasekharbh
Copy link
Author

correct @ramondeklein

@ramondeklein
Copy link
Contributor

Then it’s probably best for now to deploy the Tenant resource manually (without using Helm).

@ramondeklein ramondeklein self-assigned this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants