Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.tenant.configSecret is unusable due to default value in .secrets #2283

Closed
v1nsai opened this issue Aug 21, 2024 · 1 comment
Closed

.tenant.configSecret is unusable due to default value in .secrets #2283

v1nsai opened this issue Aug 21, 2024 · 1 comment

Comments

@v1nsai
Copy link

v1nsai commented Aug 21, 2024

Expected Behavior

I should be able to configure .tenant.configSecret in the minio tenant helm chart without errors about .secrets even though I have not entered any config for .secrets.

Current Behavior

When entering values in .tenant.configSecret, an error is encountered because .secrets has a default value, making it impossible to use due to the error checking here. I tried adding .secrets: {} to values but that didn't work.

Possible Solution

Moving the default values from the deprecated .secrets into .tenant.configSecret seems like it would do the trick.

Steps to Reproduce (for bugs)

  1. Enter values for .tenant.configSecret, do not use .secrets at all
  2. Get error about .secrets and .tenant.configSecret being mutually exclusive

Context

Not able to preconfigure an access key or a secret key in the tenant helm chart.

Regression

Seems like this is a regression due to handling for imminent deprecation of .secrets. Operator and tenant version 6.0.2

Your Environment

  • Version used (minio-operator):
    minio-tenant
  • Environment name and version (e.g. kubernetes v1.17.2):
    k3s version v1.30.3+k3s1
  • Server type and version:
    Client Version: v1.30.1
    Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
    Server Version: v1.30.3+k3s1
  • Operating System and version (uname -a):
    Ubuntu 24.04
  • Link to your deployment file:
tenant:
  name: homelab-minio
  configSecret:
    name: user-config
    existingSecret: true
@ramondeklein
Copy link
Contributor

Duplicate of #2255.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants