Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: expose more Prometheus metrics than just /minio/v2/metrics/cluster #2327

Open
BZValoche opened this issue Sep 29, 2024 · 0 comments · May be fixed by #2344
Open

Feature: expose more Prometheus metrics than just /minio/v2/metrics/cluster #2327

BZValoche opened this issue Sep 29, 2024 · 0 comments · May be fixed by #2344
Assignees

Comments

@BZValoche
Copy link

I need to have bucket metrics in grafana. I know that I can create a ScrapeConfig for it, but it is frustrating because there is some manual actions in order to achieve this, and my environment is completely managed by Argocd.

When you set prometheusOperator: true in a Tenant values, it create a scape config only on /minio/v2/metrics/cluster, which is hardcoded in the constant MinIOPrometheusPathCluster in constants.go.
Minio provides the following v2 metrics paths:

  • cluster
  • bucket
  • node
  • resource

It would be nice to have the possibility to enable the metrics or not (the values should mention the PROMETHEUS_NAMESPACE which has to be set at the operator level, btw).
A possible implementation would be to add a configuration option which could look like this:

prometheusOperatorScrape:
  cluster: true
  bucket: true
  node: false
  resource: false

Or maybe a list, so if minio adds metrics there is no need to modify the controller:

prometheusOperatorScrapes:
- cluster
- bucket

As a final word, the ScrapeInterval is also hardcoded, it'd also be nice to have it configurable.

If you find this of interest, I am happy to help with a PR.

@BZValoche BZValoche changed the title Expose more Prometheus metrics than just /minio/v2/metrics/cluster Feature: expose more Prometheus metrics than just /minio/v2/metrics/cluster Sep 29, 2024
@jiuker jiuker linked a pull request Oct 18, 2024 that will close this issue
@jiuker jiuker self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants