-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support pdb with v1 and v1beta version to control pod's deletion #1681
Conversation
@jiuker please add verification steps |
I followed the below steps
Also there are no
|
@shtripat I have fixed the |
Below scenarios work fine
And PDBs get created for pools of the tenant. Tried below scenario manually
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Verified below scenarios using kustomize plugin
- Create tenant (pdb creates)
- Expand tenant (pdb cerates for new pool)
- Decomm pool by editing YAML in console (pdb gets deleted for decomm'ed pool)
- Delete tenant (all pdbs get deleted)
@harshavardhana @pjuarezd PATL |
support pdb
Test steps:
1.start a tenant (4*4)
2. wait for tenant's status are ready
3.
kubectl get pdb -A
you will see that.4. And delete the all pod. You will see delete the pod one by one.(For MinAvailable are 3)