Sortable table: Using parseFloat to evaluate cell values removes parts of values if there is a number prefix

[natclamp-moj]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem
  • Followed all applicable steps in the debugging guide
  • Checked the FAQs on the message board for common solutions
  • Checked that your issue doesn't exist: https://github.com/ministryofjustice/moj-frontend/issues
  • Checked that there is not already a package that provides the described functionality

Description

The getCellValue function includes a parseFloat which removes any non-number after a number within a value (e.g. '123ABC' becomes '123') which means the sorting of these values is impossible.

Steps to Reproduce

1. Use the sortable table component and have data of different types in one column, such as number, string with number prefix, string, empty string, etc.
2. Sort the table using this column

Expected behaviour: If you log out the cell values, any cells with strings beginning with numbers (e.g. '123A') will have been converted to 123 because of the parseFloat used in the getCellValue function. I expect sorting to be on the entire cell value, e.g. '123A' before '123B'.

Actual behaviour: If you have multiple similar values, this means they won't sort correctly (e.g. '123A' and '123B' would just be 123 vs 123)

Reproduces how often: 100%

Versions

3.3.1
OS: Mac Sequoia 15.2
Browser: chrome

[Whersi]

The bug was fixed, and the PR has been merged into main.