Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemoryLeak fix #3

Open
brightscorpion opened this issue Apr 21, 2016 · 0 comments
Open

MemoryLeak fix #3

brightscorpion opened this issue Apr 21, 2016 · 0 comments

Comments

@brightscorpion
Copy link

Hey, I think this is an awesome project and I love what it does and how beautifully written it is! One small problem I have found in testing is that there is a memory leak. While it can be quite small leak at the rate (30 FPS and 44.1 Hz) that one could be capturing the audio and video frames it can become quite a big leak over time causing to a crash within the apps if videos are long enough. While i am no expert on the matter of memory management as I came in to IOS development after ARC was created it seems that the issues for the leaks is retaining the body object properties in both the FLVVideoTag and the FLVAudioTag objects. I changed
@Property (atomic, retain) NSData *body;
to
@Property (nonatomic) NSData *body;
In both those files. Once the change was in place the memory stayed at around the 10MB mark.

Thanks for your time.
-BrightScorpion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant