minor cleanup

Author: ImplOfAnImpl

p2p/src/net/default_backend/mod.rs

@@ -146,12 +146,6 @@ where
 impl MessagingService for MessagingHandle {
     async fn send_message(&mut self, peer_id: PeerId, message: SyncMessage) -> crate::Result<()> {
         // Note: send_message was made async to be able to use a bounded channel in tests.
-        // TODO: it may make sense to use a bounded channel in production as well. One possible
-        // reason for this might be to limit the number of BlockResponse messages that can exist
-        // at the same time. E.g. currently sync::Peer will produce a BlockResponse for each
-        // requested block almost immediately. The maximum number of simultaneously requested
-        // blocks is 500 per peer, a block can be up to 1Mb in size, so several malicious peers
-        // can eat up several Gb of RAM on the node.
         Ok(self.command_sender.send(types::Command::SendMessage {
             peer_id,
             message: message.into(),

p2p/src/sync/peer_v1.rs

@@ -290,23 +290,17 @@ where
                     .await?;
 
                 if headers.is_empty() {
-                    log::warn!(
-                        concat!(
-                            "[peer id = {}] Got new tip event with block id {}, ",
-                            "but there is nothing to send"
-                        ),
+                    log::debug!(
+                        "[peer id = {}] Got new tip event with block id {}, but there is nothing to send",
                         self.id(),
                         new_tip_id,
                     );
                 } else if best_block_id != new_tip_id {
                     // If we got here, another "new tip" event should be generated soon,
                     // so we may ignore this one (and it makes sense to ignore it to avoid sending
                     // the same header list multiple times).
-                    log::warn!(
-                        concat!(
-                            "[peer id = {}] Got new tip event with block id {}, ",
-                            "but the tip has changed since then to {}"
-                        ),
+                    log::info!(
+                        "[peer id = {}] Got new tip event with block id {}, but the tip has changed since then to {}",
                         self.id(),
                         new_tip_id,
                         best_block_id
@@ -357,9 +351,6 @@ where
     async fn request_headers(&mut self) -> Result<()> {
         let locator = self.chainstate_handle.call(|this| Ok(this.get_locator()?)).await?;
         if locator.len() > *self.p2p_config.protocol_config.msg_max_locator_count {
-            // Note: msg_max_locator_count is not supposed to be configurable outside of tests,
-            // so we should never get here in production code. Moreover, currently it's not
-            // modified even in tests. TODO: make it a constant.
             log::warn!(
                 "[peer id = {}] Sending locator of the length {}, which exceeds the maximum length {:?}",
                 self.id(),

p2p/src/sync/peer_v2.rs

@@ -287,11 +287,8 @@ where
                     .await?;
 
                 if headers.is_empty() {
-                    log::warn!(
-                        concat!(
-                            "[peer id = {}] Got new tip event with block id {}, ",
-                            "but there is nothing to send"
-                        ),
+                    log::debug!(
+                        "[peer id = {}] Got new tip event with block id {}, but there is nothing to send",
                         self.id(),
                         new_tip_id,
                     );
@@ -300,10 +297,7 @@ where
                     // so we may ignore this one (and it makes sense to ignore it to avoid sending
                     // the same header list multiple times).
                     log::warn!(
-                        concat!(
-                            "[peer id = {}] Got new tip event with block id {}, ",
-                            "but the tip has changed since then to {}"
-                        ),
+                        "[peer id = {}] Got new tip event with block id {}, but the tip has changed since then to {}",
                         self.id(),
                         new_tip_id,
                         best_block_id
@@ -354,10 +348,6 @@ where
     async fn request_headers(&mut self) -> Result<()> {
         let locator = self.chainstate_handle.call(|this| Ok(this.get_locator()?)).await?;
         if locator.len() > *self.p2p_config.protocol_config.msg_max_locator_count {
-            // Note: msg_max_locator_count is not supposed to be configurable outside of tests,
-            // so we should never get here in production code. Moreover, currently it's not
-            // modified even in tests. TODO: make it a constant.
-            // See https://github.com/mintlayer/mintlayer-core/issues/1201
             log::warn!(
                 "[peer id = {}] Sending locator of the length {}, which exceeds the maximum length {:?}",
                 self.id(),