-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Findings Report for all organizations in Crisis Room #3881
Comments
The order to show the data can be as follows: DO WE HAVE TO SHOW ALL OBSERVED AT?
OR the order is:
|
The first stage is just the usual single-org findings-page with its search and filter options, but for all organisations at once; similar to how the all-tasks page is now built. (No fancy dashboards or reports needed for now, but indeed nice to have in the future) By the way, Assets to scan should be the OOI with L1 or higher that are 'declared'/'submitted by the external DB boefje'. But that does not matter as much as the usual findings-page filters apply, so it can be changed by the end-user |
As disscussed with @underdarknl: a vanilla implementation querying all organisations for all findings may cause too much overhead on some systems. Therefore the MVP approach will be to only show the results after applying a filter (e.g. only show all critical findings, or all findings matching a specific string) |
About this feature
Detailed description
On the Crisis Room page for all organizations we want to create an overview with all the identified findings for all the organizations of the member. This overview should look like the table in the current Findings Report.
In the feature we want to create something like a Dashboard, so we'll start working towards that functionality with this ticket.
Feature benefit/User story
As a user, I want to see all Findings for all my organizations in one overview, so that I can easily see what's happening with the assets across all my organizations.
Specifications
The implementation should include…
Additional information
Any additional information, considerations, or context that might be helpful for understanding or evaluating the feature request.
Design
Figma link
The design implementation file for the current V1 MVP version of an aggregate findings report: https://www.figma.com/design/n04sOVtUJP9UAXICSq8zQu/%E2%9C%85-KAT-%7C-Approved-%7C-Reports-Content?node-id=2421-6827&t=JjvBXz1GnopnW88u-1
The design implementation file for MVP findings on the crisis room on 'all organisations' level:
https://www.figma.com/design/jDLNUhJ5GeQ4uoPagn2qrs/%E2%9C%85-KAT-%7C-Approved-%7C-Dashboard?node-id=2355-10110&t=yHxkPleycbgfnu16-1
Implementation
Possible solution
Table should look like this:
--- Table with all identified Findings for this organization
--- Table with all identified Findings for this organization
--- Table with all identified Findings for this organization
Steps:
2.1 Create a ReportRecipe (and schedule) for this organization.
(with Findings Report - All ewe_types - L1 and higher - daily - aggregate report)
2.2 Add the organization and the ReportRecipe id to the dashboard database
Alternatives considered
We thought about re-using the Findings page, but then for all organizations. But this is way to slow to use. We've to deal with a lot of API-calls, which isn't good for the performance. That's why we'll create a ReportRecipe to show the Findings.
The text was updated successfully, but these errors were encountered: