Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

"react-rails fork for use with this workflow" from TODOs #13

Open
patbenatar opened this issue Feb 14, 2016 · 9 comments
Open

"react-rails fork for use with this workflow" from TODOs #13

patbenatar opened this issue Feb 14, 2016 · 9 comments

Comments

@patbenatar
Copy link

Hey @mipearson — I noticed this in the TODOs on the README and I'm interested in helping out if I can. Did you have any ideas or plans for this that I can use as a starting point?

P.S. nifty package you got here, thanks for it!

@mipearson
Copy link
Owner

It's in progress - need to get docs correct & redo the demo repository. See https://github.com/mipearson/webpack-rails/tree/React

@mipearson
Copy link
Owner

Also, thanks :)

@mcoetzee
Copy link

mcoetzee commented Nov 1, 2016

Thanks for all the work over here - I really like the look of this gem. I was just wondering whether this todo entails the equivalent of the 'react_component' view helper and the react_ujs jazz provided by react-rails? We make heavy usage of it (where we don't do any server rendering at this stage).

@mipearson
Copy link
Owner

@mcoetzee It's more adding a helper to the existing react-rails gem so that server side rendering works.

We also use the react-rails gem at Marketplacer along with webpack-rails - we just don't use their bundled react.

@juanca
Copy link

juanca commented Nov 1, 2016

I would appreciate some documentation on webpack-rails + server-side react rendering. We're still in the process of killing the asset pipeline but would love to figure out how to get server-side rendering with webpack in rails.

@mipearson
Copy link
Owner

We're not using it yet, unfortunately. I have a prototype branch that's been working for a long time, but I need to get a demo environment/documentation together. See comment above.

@juanca
Copy link

juanca commented Nov 1, 2016

Sounds good. I'll try to give it a go and provide feedback.

@mcoetzee
Copy link

mcoetzee commented Nov 1, 2016

@mipearson Ah thanks ok I'm on the same page now. May I ask whether you guys are doing something special in order to bundle react_ujs? I was thinking today that it could be a good idea to put the react_ujs code up on NPM...

@mipearson
Copy link
Owner

Oh, right. There's an example of what we're doing in the React branch - we vendor our own copy of the react_ujs file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants