Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Lack of development value breaks production #76

Open
bpinto opened this issue Jan 13, 2017 · 0 comments
Open

Lack of development value breaks production #76

bpinto opened this issue Jan 13, 2017 · 0 comments

Comments

@bpinto
Copy link

bpinto commented Jan 13, 2017

When using webpack to generate assets server side, e.g. PDF, the dev_server.host is not set. Is there a reason why the host calculation below is not inside the dev_server.enabled check?

host = ::Rails.configuration.webpack.dev_server.host
host = instance_eval(&host) if host.respond_to?(:call)

if ::Rails.configuration.webpack.dev_server.enabled
  paths.map! do |p|
    "#{protocol}://#{host}:#{port}#{p}"
  end
end

paths

Ref: https://github.com/mipearson/webpack-rails/blob/master/lib/webpack/rails/helper.rb#L24-L33

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant