Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests should skip instead of fail for users without QE #47

Closed
stevetorr opened this issue Sep 13, 2019 · 1 comment
Closed

Unit tests should skip instead of fail for users without QE #47

stevetorr opened this issue Sep 13, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@stevetorr
Copy link
Contributor

As is, the tests which involve calling Espresso fail if the PWSCF command is not found.
It would be nice if the PWSCF command was not detected for the unit tests for calling QE to not fail, but simply be skipped. This may be more informative to the user, as there are reasons why it could fail in attempting to call QE which would require debugging.
We could also print a message encouraging the user to fix their environment variable.

@stevetorr stevetorr added the enhancement New feature or request label Sep 13, 2019
@stevetorr stevetorr self-assigned this Sep 13, 2019
@stevetorr
Copy link
Contributor Author

stevetorr commented Sep 13, 2019

Working on this now, can be done with the following command:

@pytest.mark.skipIf(not os.environ.get('PWSCF_COMMAND', False), 'PWSCF_COMMAND not found ' 'in environment: Please install Quantum ' 'ESPRESSO and set the PWSCF_COMMAND env. ' 'variable to point to pw.x.')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants