-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kernel Benchmarks #62
Comments
It might be good to use serialization methods mentioned in #16 and #64. I'm not sure if it would be better to store structured data, or just the bare minimum in the form of arrays. I'm thinking it may be easier for cross-language compatibility to use JSON for information and scalar parameters and hdf5 as the data format for bond arrays, cross bond dists, etc.. |
I endorse the use of the serialization methods! There's a PR up now that allows for GPs to be serialized as JSON files so we could just pass the models around: #64 The hdf5 format could be useful for efficiency for large training data sets, but I think we can cross that bridge once we get there (such as if sparse GPs make huge training sets feasible to work with). JSON isn't the most efficient option, strictly, for storing big arrays, but they are implemented right now and allow for storing everything you need in one .json file (either for a collection of structures representing a trajectory, a set of environments processed from a structure, or an entire GP). |
No reason we can't have both! hdf5 will be useful for the kernel acceleration that David is looking into now. |
Sounds good! hdf5 isn't mission critical for me right now, so @dmclark17, feel free to assign yourself to #16 , or we can open a new issue for hdf5 serialization and you can format it in a way that makes the most sense with your benchmarks :) |
Before trying to make any kernel optimizations, I thought it would be good to make a suite of benchmarks so we can easily and consistently measure any performance boosts.
I am thinking a two phase benchmark would work well.
The text was updated successfully, but these errors were encountered: