Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation domain belongs to Kubernetes #113

Open
sftim opened this issue Dec 8, 2022 · 0 comments
Open

Annotation domain belongs to Kubernetes #113

sftim opened this issue Dec 8, 2022 · 0 comments

Comments

@sftim
Copy link

sftim commented Dec 8, 2022

I notice that this project uses the domain backup.kubernetes.io for annotations, such as backup.kubernetes.io/deltas.

The friendly thing to do is for the project to use its own domain (or, get the Kubernetes project to register an official annotation).

The bug here is that k8s-snapshot is using an unregistered annotation. You could switch to cloud.elsdoerfer.name/k8s-backup-deltas for example, or register a different domain and use that. Could be like k8s-snapshot.something.example/deltas.

It's OK to deprecate the old annotation and support it indefinitely; it's better to switch and document / recommend using the updated annotation though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant