Adding label in snapshot

[sebglon]

Can we add static label or copy label from disk to snapshot?
a good idea can to to permit json templating with PV/PVC description.

[miracle2k]

Manual labels, or copying labels from the disk is a neat idea, though I do wonder if we should do it, because we are potentially extending the interface that backends have to implement.

What's the use case specifically? I am not sure what you mean by JSON templating either. Can you explain more?

[haizaar]

+1 for that.

My use case is spending management. We label all our GCP resources by "service" label to help breaking down the spending later on. I would account snapshots costs as part of the respective disk/resource/service costs. Therefore I would like to be able to specify either:

• Additional labels names to be copied from the original resource
• Or even manually set desired label key/val in annotations

We don't need anything fancy like templating. KISS will work great.

[iakat]

You can set custom labels with environment variables: https://github.com/miracle2k/k8s-snapshots/blob/d4af616c1641465b0367054166cc2c5a9de0326f/k8s_snapshots/config.py

pass SNAPSHOT_AUTHOR_LABEL and SNAPSHOT_AUTHOR_LABEL_KEY to override the defaults.

[mdnfiras]

hi, have this been implemented? or work in progress?

[mdnfiras]

i don't know why @sim1 's comment is downvoted, it actually works and can serve as a temporary workaround if you need just one label.