Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail with Invalid formatter u on OCaml 5 #20

Closed
Leonidas-from-XIV opened this issue Dec 22, 2022 · 2 comments
Closed

Tests fail with Invalid formatter u on OCaml 5 #20

Leonidas-from-XIV opened this issue Dec 22, 2022 · 2 comments

Comments

@Leonidas-from-XIV
Copy link

While building the revdeps for Mirage, Conan fails on OCaml 5.0:

lint (assert false / exception): FAIL

When given the input:

    "CI\175\226j\154\237\132&\140\1974\004O\018\227\209\237ZGm\202\202D\127\020\180;\019\173Z\187\151%\149\223+\244n\156c\027\148"
    
the test threw an exception:

    Invalid_argument("Invalid formatter u")
    Raised at Stdlib.invalid_arg in file "stdlib.ml", line 30, characters 20-45
    Called from Conan__Fmt.go in file "src/fmt.ml", line 618, characters 24-44
    Called from Conan__Fmt.ty_of_string in file "src/fmt.ml", line 638, characters 18-30
    Called from Conan__Tree.key_of_ty in file "src/tree.ml", line 195, characters 21-50
    Called from Conan__Tree.format_of_ty in file "src/tree.ml", line 242, characters 18-38
    Called from Conan__Process.process_fmt in file "src/process.ml", line 16, characters 31-51
    Called from Conan__Process.process.(fun) in file "src/process.ml", line 53, characters 25-54
    Called from Conan__Process.descending_walk.iter in file "src/process.ml", line 131, characters 8-68
    Called from Conan__Process.descending_walk.iter.(fun) in file "src/process.ml", line 134, characters 12-69
    Called from Conan__Process.descending_walk.iter.(fun) in file "src/process.ml", line 134, characters 12-69
    Called from Conan_string.run in file "string/conan_string.ml", line 148, characters 25-79
    Called from Dune__exe__Fuzz.(fun) in file "fuzz/fuzz.ml", line 33, characters 8-38
    Called from Crowbar.gen_apply.go.(fun) in file "src/crowbar.ml", line 325, characters 16-19

I tried submitting a PR but I don't quite understand where the u is coming from.

@dinosaure
Copy link
Member

Fixed by #21

@Leonidas-from-XIV
Copy link
Author

Excellent, thanks for the super fast fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants