Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close fd when aborting a merge #325

Open
icristescu opened this issue May 10, 2021 · 1 comment · Fixed by #326
Open

Close fd when aborting a merge #325

icristescu opened this issue May 10, 2021 · 1 comment · Fixed by #326
Labels
layered-store

Comments

@icristescu
Copy link
Contributor

When a merge is aborted, the fd for the merge file is not closed.
@icristescu icristescu assigned icristescu and unassigned icristescu May 10, 2021
@mattiasdrp mattiasdrp mentioned this issue May 20, 2021
Merged
@icristescu
Copy link
Contributor Author

Reopening because #326 only fixes the issue for the merge file. But as pointed out by @mattiasdrp in #326 (comment), the same issue also occurs for the log_async file: the file descriptor is not closed in case of an aborted merge.

@icristescu icristescu reopened this Jul 15, 2021
@tomjridge tomjridge mentioned this issue Nov 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
layered-store
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closing merge file_descr when aborting mattiasdrp/index
1 participant
@icristescu