Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid use of functor-level state for tracking statistics #373

Open
tomjridge opened this issue Nov 8, 2021 · 2 comments
Open

Avoid use of functor-level state for tracking statistics #373

tomjridge opened this issue Nov 8, 2021 · 2 comments

Comments

@tomjridge
Copy link
Contributor

tomjridge commented Nov 8, 2021 •
edited by craigfe
Loading

Stats record is supposed to be per-index, but currently it is a global variable; presumably we should change this
@craigfe craigfe changed the title Stats record is supposed to be per-index, but currently it is a global variable; presumably we should change this Avoid use of functor-level state for tracking statistics Nov 8, 2021
@craigfe
Copy link
Member

craigfe commented Nov 8, 2021

Similar to mirage/irmin#1528.

Perhaps @maiste's work on Grafana & exposing these metrics will provide some impetus for improving this.

@maiste
Copy link
Contributor

maiste commented Nov 8, 2021

Unfortunately, my current implementation is Tezos specific and work on top of the actual implementation.

I agree with you, but I currently have no good suggestion to solve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomjridge @maiste @craigfe