Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

irmin-pack: add an option to force fsync on flush #886

Closed
samoht opened this issue Nov 14, 2019 · 4 comments
Closed

irmin-pack: add an option to force fsync on flush #886

samoht opened this issue Nov 14, 2019 · 4 comments
Labels
type/question Any question

Comments

@samoht
Copy link
Member

samoht commented Nov 14, 2019

Similar to mirage/index#126
@samoht
Copy link
Member Author

samoht commented Jul 12, 2020

Now that #1010 is merged, we should be using fsync too. /cc @craigfe

@craigfe
Copy link
Member

craigfe commented Jul 12, 2020 •
edited
Loading

Not strictly the same, but there was some discussion of fsync-ing as part of irmin-pack here: #1008 (comment).

It still makes sense to provide fsync as an opt-in.

/cc @icristescu.

@samoht
Copy link
Member Author

samoht commented Dec 2, 2020

Do we still need this? /cc @icristescu and @craigfe

@maiste maiste added type/question Any question and removed users/tezos labels Jan 7, 2022
@samoht
Copy link
Member Author

samoht commented Jan 7, 2022

Closing this as it doesn't seem necessary.

@samoht samoht closed this as completed Jan 7, 2022
@metanivek metanivek mentioned this issue Jul 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/question Any question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samoht @maiste @craigfe