Adapt close documentation to really close the flow. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinosaure
approved these changes
Dec 19, 2023
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Dec 19, 2023
…rs (4.0.0) CHANGES: - Redefine `close` semantics, which no longer is a `` shutdown `read_write `` (mirage/mirage-flow#49 @hannesm) - Add ``shutdown : flow -> [ `read | `write | `read_write ] -> unit Lwt.t`` (@djs55 @hannesm mirage/mirage-flow#16 mirage/mirage-flow#18 mirage/mirage-flow#48) - Remove SHUTDOWNABLE signature (@djs55 mirage/mirage-flow#17, rebased into mirage/mirage-flow#48)
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Dec 19, 2023
…rs (4.0.0) CHANGES: - Redefine `close` semantics, which no longer is a `` shutdown `read_write `` (mirage/mirage-flow#49 @hannesm) - Add ``shutdown : flow -> [ `read | `write | `read_write ] -> unit Lwt.t`` (@djs55 @hannesm mirage/mirage-flow#16 mirage/mirage-flow#18 mirage/mirage-flow#48) - Remove SHUTDOWNABLE signature (@djs55 mirage/mirage-flow#17, rebased into mirage/mirage-flow#48)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
…rs (4.0.0) CHANGES: - Redefine `close` semantics, which no longer is a `` shutdown `read_write `` (mirage/mirage-flow#49 @hannesm) - Add ``shutdown : flow -> [ `read | `write | `read_write ] -> unit Lwt.t`` (@djs55 @hannesm mirage/mirage-flow#16 mirage/mirage-flow#18 mirage/mirage-flow#48) - Remove SHUTDOWNABLE signature (@djs55 mirage/mirage-flow#17, rebased into mirage/mirage-flow#48)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was a bit too fast with merging #48 and cutting a release, since IMHO it is important to include the revised intended semantics of
close. Does this change look good (@djs55?)? If yes, I'd be happy to merge and release as part of 4.0.0.