Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsoo support #378

Open
copy opened this issue Nov 22, 2018 · 2 comments
Open

jsoo support #378

copy opened this issue Nov 22, 2018 · 2 comments

Comments

@copy
Copy link

copy commented Nov 22, 2018

I'd like to use mirage-tcpip in a project using JavaScript using js_of_ocaml. The only piece that is missing is an OCaml (or JavaScript) implementation of the tcp checksum calculation.

As a quick-and-dirty fix, I ported the C implementation to OCaml and it seems to be working fine: patch. It's missing a non-allocating version for the _list variant. It'll also need to be properly integrated with the build system so that the native version will be selected for native builds and the pure version of jsoo builds.

@avsm
Copy link
Member

avsm commented Dec 13, 2018

This sounds good; please do send in a PR with the JS implementation and I'll fix up the build system to integrate it.

@samoht
Copy link
Member

samoht commented Dec 14, 2018

Would it make sense to extend and use mirage/checkseum for this? /cc @dinosaure

@hannesm hannesm mentioned this issue Jan 2, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants