-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 32bit? #71
Comments
@samoht Hmm, why does 32-bit ints limit it to 16MiB? |
|
I guess - I still don't understand the issue though. What is it about the 31-bit int that limits things to 16MiB? Don't you still get 1GB of positive integers with the |
@cfcs I have no idea anymore how I computed that 16 MiB limit ... |
Anyway, I always bid 63-bit lengths are welcome! |
Seems that the offset/length are currently
int
which limit the usability on 32bit architectures to 16MiB buffers. This is annoying, but changing offsets and lenght toint64
is a large API break that I would like to avoid.So it might make sense to work with in64 internally, but keep the same signatures for len and offset, but expose
len64
andoffset64
which returns something valid (and make the normal function fail in case of overflow). Not sure if the runtime coast is worth the pain though ...The text was updated successfully, but these errors were encountered: