-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mirage enabled even when using --proxy
flag
#2558
Comments
cc @deepfryed |
@Techn1x sorry for churn, fix published in v3.0.1 |
Thanks so much! You do great work! I am just glad to see things moving in mirage land :) |
@Techn1x @SergeAstapov I appreciate the report and the quick response, as my team encountered a related issue on Even after updating to function routes() {
this.passthrough();
// removed all other overrides
} We're not sure yet if the Windows issue is an existing one, either in (Could be hard-coded |
@ijlee2 thank you for the pull request! This is released as v3.0.2 |
It looks like this PR #2495 released 2 weeks ago under 3.0.0-alpha.4 has removed the
config/environment.js
fileThat
config/environment.js
file had ausingProxy()
function that would setENV['ember-cli-mirage'].usingProxy
to true if proxy flag was sethttps://github.com/miragejs/ember-cli-mirage/pull/2495/files#diff-77d6e2aab53cbf594475ecab6eac3882cd95a1c3d95085833caa58c39cb0a910L4-L11
When
usingProxy
is true, that would disable mirage server in the initializerember-cli-mirage/packages/ember-cli-mirage/app/initializers/ember-cli-mirage.js
Line 54 in dc38525
Right now nothing sets that
usingProxy
property in the config, so mirage ends up being enabled even when proxies are setThis seems like an unintentional change (wasn't mentioned in 3.0.0 Breaking Changes)
The text was updated successfully, but these errors were encountered: