Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version and Git SHA not properly passed in #139

Closed
mircea-pavel-anton opened this issue Dec 14, 2024 · 1 comment · Fixed by #150
Closed

Version and Git SHA not properly passed in #139

mircea-pavel-anton opened this issue Dec 14, 2024 · 1 comment · Fixed by #150

Comments

@mircea-pavel-anton
Copy link
Collaborator

When the container starts up, it prints these following lines:

{
  "level": "info",
  "msg": "starting external-dns-provider-mikrotik",
  "time": "2024-12-13T07:00:26Z"
}
{
  "level": "info",
  "msg": "version: local (?)",
  "time": "2024-12-13T07:00:26Z"
}

Instead, it should print the version number and the SHA of the commit that generated that release.

Relevant files:

@mr-borboto
Copy link
Contributor

mr-borboto bot commented Dec 19, 2024

🎉 This issue has been resolved in version 1.2.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@mr-borboto mr-borboto bot added the released label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant