Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOS formatting causes error on Mac OS X #1

Closed
delucis opened this issue Jul 16, 2016 · 4 comments
Closed

DOS formatting causes error on Mac OS X #1

delucis opened this issue Jul 16, 2016 · 4 comments

Comments

@delucis
Copy link

delucis commented Jul 16, 2016

When I try to run build-compilej on Mac OS X 10.9.5 I get the following error:

env: node\r: No such file or directory

This is due to the DOS formatting of bin/build-compilej, which uses CRLF rather than LF encoding for newline characters.

Happy to submit a pull request if you like.

@mirhec
Copy link
Owner

mirhec commented Jul 25, 2016

Thank you for the information, i haven't tested it yet on a Mac OS. Yes you can submit a pull request for this.

@delucis
Copy link
Author

delucis commented Jul 28, 2016

When I clone this repo, bin/build-compilej is actually showing up as already formatted using LF encoding, so I can’t PR to change the CRLF encoding. My guess is that maybe git is managing the line endings automatically somehow, but that npm publish does not, so the published package from your machine contains a CRLF-encoded file, but the git repository does not. This issue may shed some vague light: npm/npm#12371.

No idea if simply re-cloning from GitHub, and running

npm version patch
npm publish

would fix this or not. Seem to have dug up rather more than I expected!

@mirhec
Copy link
Owner

mirhec commented Aug 2, 2016

This should be fixed now, I changed the line endings to LF and published it again (version 1.0.8). Can you check it on your Mac OS?

@delucis
Copy link
Author

delucis commented Aug 2, 2016

It works! Thanks for taking the time to fix it.

@delucis delucis closed this as completed Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants