Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest ppx_sexp_conv #379

Closed
Chris00 opened this issue May 15, 2018 · 4 comments
Closed

Update to the latest ppx_sexp_conv #379

Chris00 opened this issue May 15, 2018 · 4 comments

Comments

@Chris00
Copy link

Chris00 commented May 15, 2018

Please update to the latest version of ppx_sexp_conv. Indeed, trying to install tls otherwise requires a lot of downgrades...

@copy
Copy link

copy commented May 16, 2018

I checked, and tls is already compilable with ppx_sexp_conv>=v0.11.1 (it doesn't have the bug that nocrypto suffers from). ppx_sexp_conv>=v0.11.1 also doesn't have a dependency on Base.

@hannesm
Copy link
Member

hannesm commented May 16, 2018

yes, we should make a v0.11.1 compatible release of tls and x509, but a precondition is nocrypto being able to cope with v0.11.1 (there's a PR mirleft/ocaml-nocrypto#146). once that is merged and released, I'll adapt both tls and x509 to deal with ppx_sexp_conv v.0.11.1+. both need modifications to the META files (similar to nocrypto) to reflect the runtime dependencies.

@hannesm
Copy link
Member

hannesm commented Aug 24, 2018

#381 adds these runtime dependencies (soon to be merged and released)

@hannesm
Copy link
Member

hannesm commented Aug 24, 2018

#381 is merged now, expect a release soon

@hannesm hannesm closed this as completed Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants