Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2P + SFU #127

Closed
SirRomeo9029 opened this issue Nov 30, 2022 · 1 comment
Closed

P2P + SFU #127

SirRomeo9029 opened this issue Nov 30, 2022 · 1 comment
Labels
question Further information is requested

Comments

@SirRomeo9029
Copy link

SirRomeo9029 commented Nov 30, 2022

Hey @miroslavpejic85,
So I was thinking of opening a pull request to this repository. And before opening the request I wanted to test my edits, and it didn't work. After an hour of staring at code, I tried it again and it did worked!!

Soon I realized it was some type of error in STUN/TURN server. And I thought of adding a hybrid WebRTC system in MiroTalk, an SFU and P2P (if WebRTC Mesh fails, SFU takes over). I tried to add in the SFU with MediaSoup but it actually didn't work.

Is there a way we can add a hybrid system to Mirotalk (if WebRTC Mesh fails then SFU takes its place)?

Thank You,

Note: My English is not the best...I hope you get my point of hybrid system!

@SirRomeo9029 SirRomeo9029 changed the title SFU vs P2P!! P2P + SFU Nov 30, 2022
@miroslavpejic85 miroslavpejic85 added the question Further information is requested label Dec 1, 2022
@miroslavpejic85
Copy link
Owner

miroslavpejic85 commented Dec 1, 2022

Hello @SirRomeo9029 and welcome! :)

Is there a way we can add a hybrid system to Mirotalk (if WebRTC Mesh fails then SFU takes its place)?

Currently not, this version is strictly P2P, if you want to try SFU, check out the MiroTalk SFU project here

The Difference here

Please, join with us on Discord, for questions, discussions like this one.

Thank you and have a nice day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants