Skip to content
This repository was archived by the owner on Jul 18, 2018. It is now read-only.

Commit ec49f96

Browse files
nyaxtCommit Bot
authored and
Commit Bot
committed
[ES6 modules] Update #internal-module-script-graph-fetching procedure
This CL implements the changes introduced in whatwg html spec PR: whatwg/html#2674 Summary: - "final result" is now simply the "module script", instead of previous "descendant module script" which was used to report where error occurred. - "#fetch-the-descendants-of-a-module-script" assumes (actually asserts) that all module specifiers are valid, as now it is guaranteed that their failure is handled at ModuleScript::Create. - ModuleTreeLinker::NotifyOneDescendantFinished now waits for all descendants fetch to complete, even in error cases. -- This matches spec procedure precisely, but we can optimize here later while keeping the behavior. - ModuleScriptLinker now only triggers instantiate on module tree root. (iff ModuleGraphLevel == kTopLevelModuleFetch) -- V8 is now responsible for instantiating the descendant tree + keeping their instantiation status as module script's record's [[Status]] (accessible via ModuleScript::RecordStatus() in Blink) -- UninstantiatedInclusiveDescendants() is removed, as it is no longer used. With this change, Blink now conforms to all module script WPTs! Bug: 594639, 727299, whatwg/html#2674 Change-Id: I7354e00820dd222f30b4a4eba1d3cf8c1b319798 Reviewed-on: https://chromium-review.googlesource.com/540960 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#483957}
1 parent 92a96f7 commit ec49f96

File tree

4 files changed

+167
-299
lines changed

4 files changed

+167
-299
lines changed

Diff for: third_party/WebKit/LayoutTests/TestExpectations

-8
Original file line numberDiff line numberDiff line change
@@ -1757,14 +1757,6 @@ crbug.com/705125 virtual/mojo-loading/http/tests/security/suborigins/crossorigin
17571757
# This test fails with the stable release mode.
17581758
crbug.com/694958 virtual/stable/http/tests/navigation/same-and-different-back.html [ Skip ]
17591759

1760-
# Failing because of module-related implementation/test issues.
1761-
crbug.com/594639 external/wpt/html/semantics/scripting-1/the-script-element/module/errorhandling.html [ Failure ]
1762-
crbug.com/594639 external/wpt/html/semantics/scripting-1/the-script-element/module/evaluation-error-1.html [ Failure ]
1763-
crbug.com/594639 external/wpt/html/semantics/scripting-1/the-script-element/module/evaluation-error-2.html [ Failure ]
1764-
crbug.com/594639 external/wpt/html/semantics/scripting-1/the-script-element/module/evaluation-error-3.html [ Failure ]
1765-
crbug.com/594639 external/wpt/html/semantics/scripting-1/the-script-element/module/evaluation-error-4.html [ Failure ]
1766-
crbug.com/594639 external/wpt/html/semantics/scripting-1/the-script-element/module/slow-cycle.html [ Failure ]
1767-
17681760
# This test has a failure console message with specific performance
17691761
# numbers so a consistent baseline cannot be added. This test could be
17701762
# imported if the test passed or if the results for testharness tests

0 commit comments

Comments
 (0)