Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Extension API version 2 update #164

Open
MiaoMint opened this issue Jan 8, 2024 · 11 comments · May be fixed by #255
Open

[WIP] Extension API version 2 update #164

MiaoMint opened this issue Jan 8, 2024 · 11 comments · May be fixed by #255
Assignees
Labels
enhancement New feature or request

Comments

@MiaoMint
Copy link
Member

MiaoMint commented Jan 8, 2024

Add @tags metadata for filtering extensions

image

The option to filter by tag will be added to the extension repository page

Removing class only requires writing specific methods

image

Simply write it to the top level of the code, without wrapping the class

Miru-specific operations are performed only with Miru objects

image

For example, Miru.registerSetting

Add Miru.rawRequest method

Get Response header and will not automatically add baseUrl

Add Miru.storage related methods for persistent data storage

Add methods to read and write cookies

Show messages from extensions

@MiaoMint MiaoMint added the enhancement New feature or request label Jan 8, 2024
@MiaoMint MiaoMint self-assigned this Jan 8, 2024
@MiaoMint MiaoMint changed the title Extension API version 2 update [WIP] Extension API version 2 update Jan 8, 2024
@MiaoMint MiaoMint pinned this issue Jan 8, 2024
@MiaoMint
Copy link
Member Author

MiaoMint commented Jan 8, 2024

Compatible with older extensions without changes, to use version 2 features you need to set the metadata @apiVersion to 2.

image

@OshekharO
Copy link
Member

Compatible with older extensions without changes, to use version 2 features you need to set the metadata @apiVersion to 2.

image

In case I add @apiversion 2 and doesn't make any other changes will it break the extension? Also tag is compulsory or optional?

@bachig26
Copy link
Contributor

bachig26 commented Jan 8, 2024

In case I add @apiversion 2 and doesn't make any other changes will it break the extension?

from the outlook of this looks like it'll break the extension.

Also tag is compulsory or optional?

also the tag looks only for filter similar to '@ICON', '@license', etc.

@MiaoMint
Copy link
Member Author

MiaoMint commented Jan 8, 2024

@OshekharO

Adding @apiVersion 2 to the previous extensions will break them, but don't worry, the previously written extensions do not need to be modified and can still function properly.

@tags is not a required field

@MiaoMint MiaoMint mentioned this issue Jan 11, 2024
1 task
@OshekharO

This comment was marked as resolved.

@OshekharO
Copy link
Member

an extension is broken but currently I don't have time to fix it so I just added 0

 * Status int as the following:
 * 0: Down ( false )
 * 1: Ok (true) by default 

In

// ==MiruExtension==
// @status 1 ( it can be true, false also )
// ==/MiruExtension==

Adding 0 should hide the extension from application warehouse and when I change 0 to 1 in in extension it should show the extension.

@MiaoMint

This comment was marked as resolved.

@OshekharO

This comment was marked as resolved.

@MiaoMint

This comment was marked as resolved.

@OshekharO

This comment was marked as resolved.

@shashankx86
Copy link
Contributor

@MiaoMint #157

@appdevelpo appdevelpo self-assigned this Apr 21, 2024
@appdevelpo appdevelpo linked a pull request Apr 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants