pyrothc suggestion

[wentao-jiang]

I have found some issues with the soil cover in the model that you have set to a BOOL value, and I was reading the manual for the model and it mentions that this has to do with the rate of decomposition for each month, so I would suggest if you could change the soil cover to a customized 12-month data box with 0/1 to represent each month's cover. That way the model would be closer to the original model. Just like your definitions of temperature and precipitation, you could set the status for each month instead of defaulting to 12 months of cover.

[mishagrol]

@chiangwt Hello ✅

First of all, sorry for late responce!)

Good idea, but I want to clarify, you mean this parameter - bare ?

bare (bool, optional): Logical. Under bare soil conditions, bare=True.
                                Default is set under vegetated soil. Defaults to False. 

https://github.com/mishagrol/pyRothC/blob/d22bfb7747305fad735add4c8554a9965d2e53ad/pyRothC/RothC.py#L31C9-L31C9

[wentao-jiang]

@mishagrol hello,
Yes, that's what I'm talking about this parameter (soil cover), I think this parameter can be set to soil cover=np.array([0,0,0,1,1,1,1,1,1,1,1,0,0,0]), which means that the soil is covered from April to September, and the rest of the months represent that the soil is bare.

[wentao-jiang]

I'm sorry, the last reply gave too many numbers, it should be 12 numbers

[mishagrol]

@chiangwt okay) I will create new branch and test it. If you have such modified version of soil cover you can create pull request)

[wentao-jiang]

@mishagrol Last time I missed two issues, the carbon input and farm yard manure of this model were also added over 12 months.

[wentao-jiang]

@mishagrol
First of all, I would like to thank the contributors for their previous modification work, which made it possible to add the definitions of FYM, Carbon Input, and Soil Bare as I suggested. But I am confused about the customization of FYM and carbon inputs, the comment says to define by time, my understanding is 500 years of simulation time (6000 months), so is it necessary to enter a list of 6000?