Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/create content-type default to "application/octet-stream" #1966

Open
razum2um opened this issue Dec 14, 2018 · 2 comments
Open

release/create content-type default to "application/octet-stream" #1966

razum2um opened this issue Dec 14, 2018 · 2 comments
Labels

Comments

@razum2um
Copy link

for example, see release done via web ui: https://api.github.com/repos/DomainDrivenArchitecture/smeagol/releases/14283686
one asset has content_type: "application/x-java-archive"

another release done via hub: https://api.github.com/repos/DomainDrivenArchitecture/smeagol/releases/14536031
has content_type: "application/octet-stream"

I think there should be a way to specify this (maybe via cmd flag)

@mislav
Copy link
Owner

mislav commented Dec 14, 2018

@mislav mislav added the feature label Dec 14, 2018
@razum2um
Copy link
Author

@mislav we can also detect it using https://github.com/gabriel-vasile/mimetype (since https://github.com/h2non/filetype has issues with container type, e.g. jar) - what do you prefer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants