pythonGH-104308: socket.getnameinfo should release the GIL (python#104307)

njsmith · blurb-it[bot] · web-flow · commit faf196213e60 · 2023-05-08T16:27:20.000-07:00
* socket.getnameinfo should release the GIL

* 📜🤖 Added by blurb_it.

---------

Co-authored-by: blurb-it[bot] &lt;43283697+blurb-it[bot]@users.noreply.github.com&gt;
diff --git a/Misc/NEWS.d/next/Library/2023-05-08-20-57-17.gh-issue-104307.DSB93G.rst b/Misc/NEWS.d/next/Library/2023-05-08-20-57-17.gh-issue-104307.DSB93G.rst
@@ -0,0 +1 @@
+:func:`socket.getnameinfo` now releases the GIL while contacting the DNS server
diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c
@@ -6883,8 +6883,10 @@ socket_getnameinfo(PyObject *self, PyObject *args)
         }
 #endif
     }
+    Py_BEGIN_ALLOW_THREADS
     error = getnameinfo(res->ai_addr, (socklen_t) res->ai_addrlen,
                     hbuf, sizeof(hbuf), pbuf, sizeof(pbuf), flags);
+    Py_END_ALLOW_THREADS
     if (error) {
         socket_state *state = get_module_state(self);
         set_gaierror(state, error);

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+:func:`socket.getnameinfo` now releases the GIL while contacting the DNS server
Original file line number	Diff line number	Diff line change
`@@ -6883,8 +6883,10 @@ socket_getnameinfo(PyObject self, PyObject args)`
`6883`	`6883`	`}`
`6884`	`6884`	`#endif`
`6885`	`6885`	`}`
	`6886`	`+ Py_BEGIN_ALLOW_THREADS`
`6886`	`6887`	`error = getnameinfo(res->ai_addr, (socklen_t) res->ai_addrlen,`
`6887`	`6888`	`hbuf, sizeof(hbuf), pbuf, sizeof(pbuf), flags);`
	`6889`	`+ Py_END_ALLOW_THREADS`
`6888`	`6890`	`if (error) {`
`6889`	`6891`	`socket_state *state = get_module_state(self);`
`6890`	`6892`	`set_gaierror(state, error);`