Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid emoji name in Emoji component crashes #143

Closed
buoyad opened this issue Nov 9, 2017 · 2 comments
Closed

Invalid emoji name in Emoji component crashes #143

buoyad opened this issue Nov 9, 2017 · 2 comments

Comments

@buoyad
Copy link

buoyad commented Nov 9, 2017

See example here: https://codesandbox.io/s/50yjo02m5k

Passing the name of an invalid emoji to Emoji crashes the app. This causes bugs that are hard to workaround on the implementation side, especially in cases where users can enter emoji names directly.

In particular, if this function didn't assume that raw strings passed in are already valid emojis, the error could be bubbled up & handled/logged rather than causing a full crasher.

Thanks for the library!

@EtienneLem
Copy link
Member

There you go, v2.2.1 has just been released: https://codesandbox.io/s/j2ropwx35v

@buoyad
Copy link
Author

buoyad commented Nov 10, 2017

Oh, thank you for the quick response/release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants