You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi there, and thanks for the library and recent update with darkMode.
I wanted to report very possible undesired effect of current default darkMode property value. Now, as per readme, it is set to true if the browser reports if the browser reports prefers-color-scheme: dark. I think that a huge amount of projects using this nice lib doesn't support theming (like mine). Then, if a user of the app has dark theme enabled in OS, but site has white background, emoji-mart would lead to regression
The pictures below show what happened in my project
before
after
I think emoji-mart shouldn't get default value for the darkMode from the browser/OS settings, as it seems to much responsibility for the widget lib and it can cause significant visual regression in the apps which do not support theming.
The text was updated successfully, but these errors were encountered:
Hi there, and thanks for the library and recent update with darkMode.
I wanted to report very possible undesired effect of current default
darkMode
property value. Now, as per readme, it is set totrue
if the browser reports if the browser reportsprefers-color-scheme: dark
. I think that a huge amount of projects using this nice lib doesn't support theming (like mine). Then, if a user of the app has dark theme enabled in OS, but site has white background, emoji-mart would lead to regressionThe pictures below show what happened in my project
before
after
I think emoji-mart shouldn't get default value for the darkMode from the browser/OS settings, as it seems to much responsibility for the widget lib and it can cause significant visual regression in the apps which do not support theming.
The text was updated successfully, but these errors were encountered: