Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] categories order including custom category working in v5.2.2 but not in v5.6.0 #951

Open
dsaket opened this issue Sep 30, 2024 · 2 comments · May be fixed by #961
Open

[Bug] categories order including custom category working in v5.2.2 but not in v5.6.0 #951

dsaket opened this issue Sep 30, 2024 · 2 comments · May be fixed by #961

Comments

@dsaket
Copy link

dsaket commented Sep 30, 2024

Following config works fine with emoji-mart@5.2.2 and the custom category is showing up in the respected order....however "custom" category doesn't even show up with emoji-mart@5.6.0 with the same config

        categories: [
          "frequent",
          "custom",    // custom category
          "people",
          "nature",
          "foods",
          "activity",
          "places",
          "objects",
          "symbols",
          "flags",
        ],
@dsaket dsaket changed the title categories order including custom category working in v5.2.2 but not in v5.6.0 [Bug] categories order including custom category working in v5.2.2 but not in v5.6.0 Sep 30, 2024
@dsaket
Copy link
Author

dsaket commented Sep 30, 2024

In fact, i checked and seems like it stopped working from v5.3.0 and onwards

@mahmed2000
Copy link

This is a consequence of 052badf.

The categories prop filters on the originalCategories, which only includes the categories in the data object. Any custom categories never get pushed to this array so they will always be excluded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants