Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean remote files job shows progress out of 1 instead of 100% #13632

Closed
1 task done
nilathedragon opened this issue Mar 29, 2024 · 1 comment
Closed
1 task done

Clean remote files job shows progress out of 1 instead of 100% #13632

nilathedragon opened this issue Mar 29, 2024 · 1 comment
Labels
1️⃣ Good First Issue This is a good problem for your first contribution. 🐛Bug Unexpected behavior packages/backend Server side specific issue/PR

Comments

@nilathedragon
Copy link
Contributor

💡 Summary

When running the remote files clean job, the job reports its progress as deleted files out of total files, which means the progress shown in the bull dashboard is too small to read.

Likely all thats needed is this line being changed from deletedCount / total to 100/total*deletedCount

🥰 Expected Behavior

The progress of cleanup should be shown in % out of 100

🤬 Actual Behavior

The progress of clean up is shown as something like 0.02134324233122

image image

📝 Steps to Reproduce

  1. Start cleanup job by purging cached remote media
  2. Observe job in Bull Dashboard

💻 Frontend Environment

* Model and OS of the device(s): MacBook Pro M1 Max, macOS Sonoma 14.4.1
* Browser: Arc 1.36.0 (Chromium Engine Version 123.0.6312.87)
* Server URL: derg.social
* Misskey: Sharkey 2024.3.1

The bug is valid for Misskey too as the suspected code is the same in Misskey & Sharkey

🛰 Backend Environment (for server admin)

* Installation Method or Hosting Service: Kubernetes
* Misskey: Sharkey 2024.3.1
* Node: 20
* PostgreSQL: 15
* Redis: 7.2.3
* OS and Architecture: Rocky Linux 9

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
@nilathedragon nilathedragon added the ⚠️bug? This might be a bug label Mar 29, 2024
@acid-chicken acid-chicken added 🐛Bug Unexpected behavior packages/backend Server side specific issue/PR 1️⃣ Good First Issue This is a good problem for your first contribution. and removed ⚠️bug? This might be a bug labels Mar 29, 2024
@t1nyb0x t1nyb0x moved this to Triage in [BUG TRACKER] Backend Apr 1, 2024
@kakkokari-gtyih
Copy link
Contributor

Done in #13633 (Githubの書式で紐づけが成されていなかった)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1️⃣ Good First Issue This is a good problem for your first contribution. 🐛Bug Unexpected behavior packages/backend Server side specific issue/PR
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants