Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STL appears even if LTL is disabled by a role #14336

Closed
1 task
5ouma opened this issue Jul 31, 2024 · 1 comment · Fixed by #14337
Closed
1 task

STL appears even if LTL is disabled by a role #14336

5ouma opened this issue Jul 31, 2024 · 1 comment · Fixed by #14337
Assignees
Labels
🐛Bug Unexpected behavior packages/frontend Client side specific issue/PR
Milestone

Comments

@5ouma
Copy link
Contributor

5ouma commented Jul 31, 2024

💡 Summary

I disable LTL for local and remote users by a role.
Before 2024.7.0-rc.5, STL is also disabled with that role. After updating 2024.7.0-rc.8, STL appeared but it outputs an error.

If I disable LTL from the Role template, STL will be disabled though.

🥰 Expected Behavior

STL is disabled with LTL.

🤬 Actual Behavior

STL appears even LTL is disabled.

📝 Steps to Reproduce

  1. Enable LTL in the Role template.
  2. Create a role with this config.
{
  "name": "Disable Local Timeline",
  "description": "Disable the local timeline to logged-in users",
  "color": null,
  "iconUrl": null,
  "isModerator": false,
  "isAdministrator": false,
  "displayOrder": 0,
  "target": "conditional",
  "condFormula": {
    "type": "or",
    "values": [{ "type": "isLocal" }, { "type": "isRemote" }]
  },
  "isPublic": false,
  "isExplorable": false,
  "asBadge": false,
  "canEditMembersByModerator": false,
  "policies": { "ltlAvailable": { "value": false, "priority": 1 } }
}

💻 Frontend Environment

* Model and OS of the device(s): iOS 17.6
* Browser: PWA
* Server URL: https://misskey.5ouma.me
* Misskey: 2024.7.0-rc.8

🛰 Backend Environment (for server admin)

* Installation Method or Hosting Service: Docker
* Misskey: 2024.7.0-rc.8
* Node:
* PostgreSQL: 16.3
* Redis: 7.2.5-alpine3.19
* OS and Architecture: macOS, amd64

For the full compose.yml, see this.
https://github.com/5ouma/homelab/blob/26aca33e59c4bbd9750d1750381a49eaee2d66ed/misskey/compose.yml

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
@5ouma 5ouma added the ⚠️bug? This might be a bug label Jul 31, 2024
@tai-cha
Copy link
Contributor

tai-cha commented Jul 31, 2024

I confirmed on latest develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Unexpected behavior packages/frontend Client side specific issue/PR
Projects
None yet
2 participants