Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Sign-in with Passkey Button #14574

Closed
1 task done
yunochi opened this issue Sep 19, 2024 · 2 comments
Closed
1 task done

Implement Sign-in with Passkey Button #14574

yunochi opened this issue Sep 19, 2024 · 2 comments
Labels
✨Feature This adds/improves/enhances a feature

Comments

@yunochi
Copy link
Contributor

yunochi commented Sep 19, 2024

Summary

Implement Login with passkey Button

image
EN: Instead of entering an ID and authenticating with a passkey, create a dedicated 'Login with Passkey' button.

JA: idから入力してpasskey認証をする代わりに、「Passkeyでログインボタン」を作成します

Purpose

photo_2024-09-19_13-40-42

WHY (EN)

Password-less login accounts have the inconvenience of having to first enter an ID and then click the login button to authenticate the passkey.
In addition, multi-account users have the inconvenience of having to enter an ID and then select a passkey from the list.
Since Misskey already uses residentKey, it is possible to skip the ID entry process and log in directly by selecting a passkey.

For reference, GitHub also adopts the same interface for its login screen.

WHY (JA)

パスワードレスログイン アカウントは、id を最初に入力してからログインボタンを押してパスキー認証をする不便があります。 さらに、複数のアカウントを持つユーザーは、id入力後にパスキーリストから選択する必要があるという不便さもあります。
MisskeyはすでにresidentKeyを使用しているため、idを入力するプロセスをスキップしてパスキーを選択してすぐにログインすることが可能です。

ちなみにgithubも同じインターフェースをログイン画面に採用しています。

Do you want to implement this feature yourself?

  • Yes, I will implement this by myself and send a pull request
@yunochi yunochi added the ✨Feature This adds/improves/enhances a feature label Sep 19, 2024
@yunochi
Copy link
Contributor Author

yunochi commented Sep 19, 2024

PRを準備しています。
Passkeyログインボタンを作成する際に、パスワードレスログインがオンになっているアカウントを入力するとパスワードフィールドが消える挙動をなくし、
ログイン方法を 1FA (Passkey) と 2FA (id/pw の後に OTP or Passkey) で確実に区別したいと思います。

I'm currently preparing a PR.
While creating a Passkey login button, I want to eliminate the behavior where the password input field disappears when you enter an account with passwordless login turned on,
and clearly distinguish the login method between 1FA (Passkey) and 2FA (ID/PW, then OTP or Passkey).

Example video

Login with passkey

Screen_Recording_20240919_160112_Chrome.mp4

Login with 2FA

Screen_Recording_20240919_160300_Chrome.mp4
  • NOTE: The black screen after selecting the passkey is the fingerprint recognition prompt. (Due to Android recording limitations)

@kakkokari-gtyih
Copy link
Contributor

Done in #14577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨Feature This adds/improves/enhances a feature
Projects
None yet
Development

No branches or pull requests

2 participants