Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an actual form element for search box #9480

Open
SoniEx2 opened this issue Jan 6, 2023 · 0 comments
Open

Use an actual form element for search box #9480

SoniEx2 opened this issue Jan 6, 2023 · 0 comments
Labels
✨Feature This adds/improves/enhances a feature packages/frontend Client side specific issue/PR

Comments

@SoniEx2
Copy link
Contributor

SoniEx2 commented Jan 6, 2023

Summary

With an actual form element, search box can be added to browser. This is similar to #7058 in that it's about "add search to browser", but unlike #7058 this is done from the in-page search box, instead of somewhere in the browser's menus.

At least Firefox supports these 2 ways to add a search engine. So we should probably support both.

However, unlike #7058, this one is non-trivial. This would likely require a new widget, at the very least.

For example, GitHub provides both OpenSearch metadata (so the browser gives the option to add GitHub search), but it also provides a proper search form, so right-clicking the search box brings up "Add a keyword for this search". It's also worth noting that the search form does something slightly different from OpenSearch: the search form is local to a project, and the OpenSearch is global to all of GitHub!

@SoniEx2 SoniEx2 added the ✨Feature This adds/improves/enhances a feature label Jan 6, 2023
@syuilo syuilo added the packages/frontend Client side specific issue/PR label Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨Feature This adds/improves/enhances a feature packages/frontend Client side specific issue/PR
Projects
None yet
Development

No branches or pull requests

2 participants