Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated and deprecating functionalities #354

Open
GiudGiud opened this issue Sep 5, 2018 · 1 comment
Open

Deprecated and deprecating functionalities #354

GiudGiud opened this issue Sep 5, 2018 · 1 comment

Comments

@GiudGiud
Copy link
Contributor

GiudGiud commented Sep 5, 2018

This issue is meant to discuss which functionalities you think have been deprecated in the code, and which functionalities will or should be deprecated.

  • In the 3D MOC branch, I think we should deprecate the backup CMFD solver. It's not necessary to have a secondary solver which is a priori less stable than the main one (to show/prove), since it has a coarser group structure. It would clean up the CMFD file a bit to delete it
  • In the 3D MOC branch, On-The-Fly transport (transport at the same time as ray-tracing, on the fly), seems to be only partly implemented, possibly because it was working at some point then got deprecated. As MOCkingbird and John's code are going this way, we might want to fix that option.
    "Reducing 3D MOC Storage Requirements with Axial On-the-fly Ray Tracing" by G. Gunow et al. shows it's 20% slower than the current way but the solver is 5 times faster now than then so that might have changed.
  • The CPU solvers are now vectorized. VectorizedSolver which follows a different approach should be re-tested and most probably deleted
  • The spectrumCalculator, initialization sweeps and chi guess, used to get a "better" starting point for the simulation, dont seem to be required anymore, even for the 3D full core case which is notoriously hard to converge. Besides, initialization sweeps are expensive and chi guess creates 0 fluxes which aren't great for CMFD.
@GiudGiud
Copy link
Contributor Author

GiudGiud commented Jul 2, 2019

As an update, OTF transport has been fixed and is still 20% slower than ray tracing for the whole s,z plane followed by transport of track angular fluxes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant