You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've pulled the latest changes on the affected branch and the issue is still present.
The issue is reproducible in docker
Description
There are several small issues with both scripts/configure.sh and scripts/build.sh that prevents building on OSX. Here are few I've run across so far:
brew installs leveldb but the header files are not available to the build. There's also the issue of using different versions of leveldb between platforms: Linux build uses version 1.2.2. brew uses the latest which is 1.2.3
configure.sh uses wget in a few places but wget is not installed by default on OSX. curl is available on OSX
build.sh hardcodes a path to gmake which is different from the default location from brew
copying nuraft headers, etc... to /use/local/ requires sudo
git submodules are not pulled in either script.
Note: I'm working on a fix for all this and will submit a pull request once I've worked through all the issues.
Code of Conduct
I agree to follow this project's Code of Conduct
The text was updated successfully, but these errors were encountered:
It appears the bash files in scripts are primarily designed to support the Dockerfile in scripts. But configure.sh includes some support for OSX. Would it be best to separate some of this for clarity? For example: local build vs Docker build. This is relevant to little things like the location of the build directory.
Affected Branch
trunk
Basic Diagnostics
I've pulled the latest changes on the affected branch and the issue is still present.
The issue is reproducible in docker
Description
There are several small issues with both
scripts/configure.sh
andscripts/build.sh
that prevents building on OSX. Here are few I've run across so far:configure.sh
useswget
in a few places butwget
is not installed by default on OSX.curl
is available on OSXbuild.sh
hardcodes a path togmake
which is different from the default location from brewnuraft
headers, etc... to/use/local/
requiressudo
git
submodules are not pulled in either script.Note: I'm working on a fix for all this and will submit a pull request once I've worked through all the issues.
Code of Conduct
The text was updated successfully, but these errors were encountered: