Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build on OSX with bash scripts #94

Closed
2 of 3 tasks
davebryson opened this issue Apr 26, 2022 · 1 comment · Fixed by #96
Closed
2 of 3 tasks

Unable to build on OSX with bash scripts #94

davebryson opened this issue Apr 26, 2022 · 1 comment · Fixed by #96
Assignees
Labels
enhancement/build-system Improves an aspect of the build system fix/bug Fixes errant behavior

Comments

@davebryson
Copy link
Contributor

Affected Branch

trunk

Basic Diagnostics

  • I've pulled the latest changes on the affected branch and the issue is still present.

  • The issue is reproducible in docker

Description

There are several small issues with both scripts/configure.sh and scripts/build.sh that prevents building on OSX. Here are few I've run across so far:

  • brew installs leveldb but the header files are not available to the build. There's also the issue of using different versions of leveldb between platforms: Linux build uses version 1.2.2. brew uses the latest which is 1.2.3
  • configure.sh uses wget in a few places but wget is not installed by default on OSX. curl is available on OSX
  • build.sh hardcodes a path to gmake which is different from the default location from brew
  • copying nuraft headers, etc... to /use/local/ requires sudo
  • git submodules are not pulled in either script.

Note: I'm working on a fix for all this and will submit a pull request once I've worked through all the issues.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@davebryson davebryson added the fix/bug Fixes errant behavior label Apr 26, 2022
@davebryson
Copy link
Contributor Author

It appears the bash files in scripts are primarily designed to support the Dockerfile in scripts. But configure.sh includes some support for OSX. Would it be best to separate some of this for clarity? For example: local build vs Docker build. This is relevant to little things like the location of the build directory.

@HalosGhost HalosGhost assigned davebryson and unassigned HalosGhost Apr 27, 2022
@HalosGhost HalosGhost added the enhancement/build-system Improves an aspect of the build system label Apr 27, 2022
@HalosGhost HalosGhost linked a pull request May 4, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement/build-system Improves an aspect of the build system fix/bug Fixes errant behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants