-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secure Minting #98
Comments
@HalosGhost You can assign this to me. I've started working on it. |
@HalosGhost Working through an implementation of secure minting, I've ran into an issue with the Atomizer sentinel. Minting transactions do not have Tx inputs. However, the Atomizer sentinel expects Tx inputs in order to forward the transaction: https://github.com/mit-dci/opencbdc-tx/blob/trunk/src/uhs/atomizer/sentinel/controller.cpp#L97. It appears the atomizer sentinel uses Tx inputs to validate a shard id. The logic I've added for secure minting performs specific minting validation if a transaction has no inputs. Otherwise a non-mint transaction, with no inputs, will be rejected. So technically valid non-mint transactions will work with the current sentinel logic. However, if I adjust the logic to support a mint transaction (no inputs), what's the best way to determine which UPDATE: On further investigation, it appears the shard also checks for inputs: https://github.com/mit-dci/opencbdc-tx/blob/trunk/src/uhs/atomizer/shard/shard.cpp#L123 |
@davebryson I just want to double-check, it sounds like you managed to find an answer to the primary question you had; is there anything else tripping you up or blocking you? |
@HalosGhost I don't think so. The only issue I see is I need to remove checking for no inputs in the atomizer architecture: https://github.com/mit-dci/opencbdc-tx/blob/trunk/src/uhs/atomizer/shard/shard.cpp#L123. But this should be ok as the transaction would never get this far if it didn't pass validation. Right now I'm merging conflicts from latest trunk. So I hope to have the initial pull request very soon. Thanks. |
Question
How can the system support secure minting of currency?
Benefit
A secure minting solution will ensure that only pre-authorized, designated, wallets can mint new currency
Proposed Solution
For an initial solution we will add the ability for sentinels to recognize and validate mint transactions. This will require:
Possible Difficulties
The proposed solution is a starting point - it may not be the final (best) solution. More research will be needed to ensure minting is as secure as possible.
Prior Work
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: