Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the regex format different between files? #156

Open
s22-tech opened this issue May 4, 2021 · 1 comment
Open

Why is the regex format different between files? #156

s22-tech opened this issue May 4, 2021 · 1 comment

Comments

@s22-tech
Copy link

s22-tech commented May 4, 2021

Hey Mitchell,

I'm just curious why the format of the regex is different between the globalblacklist.conf and the blacklist-user-agents.conf

In globalblacklist.conf they are formatted as:

BrowserMatchNoCase "(?:\b)Scrapy(?:\b)" bad_bot

while in blacklist-user-agents.conf, they're formatted as:

BrowserMatchNoCase "^(.*?)(\bScrapy\b)(.*)$" bad_bot

Can either format be used? The reason I ask is that I prefer the format in globalblacklist.conf because when using a text editor like BBEdit, when double-clicking the agent, you only get the agent, i.e. Scrapy. But when selecting it in the other one, you end up with bScrapy selected.

Thanks,
Marc

@mitchellkrogza
Copy link
Owner

mitchellkrogza commented Jun 14, 2021

I think I just forgot to update the include files, first regex is better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants